When reviewing a large changeset with magit, it can be difficult to separate meaningfull changes from purely syntactic substitutions. Using ediff to navigate the patch highlights the words changed between two lines instead of just showing a line removed and another added.
In the above screenshot the oid change to oid.hobj is a syntactic change where the new block after oid.generation != ghobject_t::NO_GEN deserves more attention.
Continue reading “tip to review a large patch with magit and ediff”
Running git_stats against Ceph master today produced the following output.
The stats before 2010 were trimmed because the report is too slow to navigate.
sudo apt-get install ruby1.9.1-dev ruby-mkrf
sudo gem install git_stats
git clone firstname.lastname@example.org:ceph/ceph.git
git_stats generate --from=07005fa1e501973846d666ed073ce64b45144d39
This is a dialog (also published on ceph.com) where Joao Luis, Ceph core developer with an intimate knowledge of the monitor, answers Loïc Dachary’s questions who discovers this area of the Ceph code base. Many answers are covered in Joao’s article Ceph’s New Monitor Changes (March 2013), with a different angle.
Continue reading “Ceph dialog : monitors and paxos”